BugFix - Track File Upload Index

[alperozturk96]

• Tests written, or not not needed

Problem

Currently, the logic implemented in FileUploadWorker processes file uploads in discrete batches, which limits our ability to track the overall upload progress accurately and total upload index is wrong. We have outer while loop to update uploads and inner for loop for uploads.

For example, when a user attempts to upload 164 files:

1. The first batch is processed, triggering a progress notification for files 1–2.
2. The second batch then triggers a notification for files 23–2.
3. The third batch triggers a notification for files 53–2
4. ... and final batch 164-2.

How to reproduce?

1. Create a folder
2. Try to upload n times file
3. Observe file upload notification

Solution

1. Refactor the FileUploadWorker logic to support uploading all files without batches, thus we can track all progress.
2. Pass totalUploadSize and use it in the worker, this will result in minimal changes.

I chose the second one

Demo

ddd.mp4

[alperozturk96]

Some calls (e.g., FilesSyncWork) to startFilesUploadJob() don't have totalUploadSize, so we need two versions of it.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	54	51
Errors	11	11

SpotBugs

Category	Base	New
Bad practice	65	65
Correctness	58	59
Dodgy code	292	280
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	1	1
Multithreaded correctness	7	7
Performance	51	48
Security	18	18
Total	500	486

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14822.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.