Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add analysis wrapper #199

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add analysis wrapper #199

wants to merge 7 commits into from

Conversation

AndyScherzinger
Copy link
Member

@stefan-niedermann
Copy link
Member

Looks like an important privacy related PR... would you mind leaving some notes about the nature of this PR? Does this include any kind of tracking or something else?

@stefan-niedermann
Copy link
Member

(or does analytics mean some kind of source code analytcis? - please clarify)

@AndyScherzinger
Copy link
Member Author

@stefan-niedermann It means static code analysis, namely lint, detekt and spotless, the analysis wrapper basically triggers the checks and compares them to the main branch results, see for example implemented in the files client: nextcloud/android#12045 (comment) same is there for talk, so I want to bring these code checks and comparison also to the common lib :)
This way the check fails if the scores degrade comparing the PR with main

@AndyScherzinger
Copy link
Member Author

I would have thought a quick look at the changes makes this very clear 😀
2023-10-20 18_38_44-Add analysis wrapper by Pull Request #199 · nextcloud_android-

@AndyScherzinger
add wrapper script
8470832 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
Update file permissions
80df713 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
fix repo name
4ba434d 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
Add ruby checkers
c2b3b9c 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
fix lint gradle command
c17a237 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
Add further spotbugs checker files
8c785d7 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the chore/analysisWrapper branch 2 times, most recently from 3a43435 to f4d2f1b Compare November 27, 2023 16:16
@AndyScherzinger
Change spotless call
382553d 
Signed-off-by: Andy Scherzinger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2. developing Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndyScherzinger @stefan-niedermann