Skip to content

Remove analysis wrapper #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndyScherzinger merged 1 commit into from
Dec 17, 2025
Merged

Remove analysis wrapper #199

AndyScherzinger merged 1 commit into from
Dec 17, 2025
+0 −83

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Oct 19, 2023

@stefan-niedermann
Copy link
Member

stefan-niedermann commented Oct 20, 2023

Looks like an important privacy related PR... would you mind leaving some notes about the nature of this PR? Does this include any kind of tracking or something else?

@stefan-niedermann
Copy link
Member

stefan-niedermann commented Oct 20, 2023

(or does analytics mean some kind of source code analytcis? - please clarify)

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Oct 20, 2023

@stefan-niedermann It means static code analysis, namely lint, detekt and spotless, the analysis wrapper basically triggers the checks and compares them to the main branch results, see for example implemented in the files client: nextcloud/android#12045 (comment) same is there for talk, so I want to bring these code checks and comparison also to the common lib :)
This way the check fails if the scores degrade comparing the PR with main

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Oct 20, 2023

I would have thought a quick look at the changes makes this very clear 😀
2023-10-20 18_38_44-Add analysis wrapper by Pull Request #199 · nextcloud_android-

@AndyScherzinger AndyScherzinger force-pushed the chore/analysisWrapper branch 4 times, most recently from f4d2f1b to 382553d Compare November 27, 2023 16:18
@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Dec 17, 2025

Since we have all the checks in place already and 💚
I am changing this PR for now removing the analysis logic given we have an established baseline already and won't need a main/PR branch comparison.

@AndyScherzinger
ci: remove analysis CI
0aef709 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger AndyScherzinger added this to the 0.31.0 milestone Dec 17, 2025
@AndyScherzinger AndyScherzinger changed the title Add analysis wrapper Remove analysis wrapper Dec 17, 2025
@AndyScherzinger AndyScherzinger merged commit bd235c7 into main Dec 17, 2025
12 of 13 checks passed
@AndyScherzinger AndyScherzinger deleted the chore/analysisWrapper branch December 17, 2025 16:50
@AndyScherzinger AndyScherzinger removed the 2. developing Work in progress label Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.31.0

Development

Successfully merging this pull request may close these issues.

2 participants

@AndyScherzinger @stefan-niedermann