[Spring Core] 정연희 미션 제출합니다 #278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add spring boot data-jpa dependency
- create layered architecture for time - use custom exception (TimeNotFoundException)
kyY00n
suggested changes
Jun 3, 2024
|
|
||
| @Service | ||
| public class TimeService { | ||
| @Autowired |
| import java.util.List; | ||
|
|
||
| @Service | ||
| public class TimeService { |
There was a problem hiding this comment.
서비스 계층을 나눠주셨군요? 계층을 나눴을 때의 장점은 어떤 것이 있었나요?
| throw new TimeNotFoundException("Time with id " + id + " not found"); | ||
| } | ||
| return timeRepository.getReferenceById(id); | ||
| } |
| if (!timeRepository.existsById(id)) { | ||
| throw new TimeNotFoundException("Time with id " + id + " not found"); | ||
| } | ||
| Time time = getTimeById(id); |
There was a problem hiding this comment.
getTimeById(id) 메서드에서 이미 존재하는 아이디인지 검증하고 있는 것 맞죠? 제거해도 좋을 것 같아요.
| Reservation newReservation = reservationService.createReservation(reservation); | ||
| String uri = "/reservations/" + newReservation.getId(); | ||
| return ResponseEntity.created(URI.create(uri)).body(newReservation); | ||
| } |
| public String setName(String name) {return this.name = name;} | ||
| public String setDate(String date) {return this.date = date;} | ||
| public String setTime(String time) {return this.time = time;} | ||
| } |
There was a problem hiding this comment.
무분별한 setter 선언은 객체지향 프로그래밍을 지키기 어렵게 하기 때문에 지양하는 것이 좋습니다..!
다음 글을 한 번 읽어보세요. setter 쓰지 말라고만 하고 가버리면 어떡해요
| if(!timeRepository.existsById(time.getId())) { | ||
| throw new TimeNotFoundException("Time with id " + time.getId() + " not found"); | ||
| } | ||
| reservation.setTime(time); |
There was a problem hiding this comment.
setter를 사용하지 않아도 reservation 객체의 time 필드는 그대로 일것 같습니다.
|
|
||
|
|
||
| @Test | ||
| void 십단계() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.