[Spring Core] 한경준 미션 제출합니다. #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 10, 2024 16:58
# Conflicts: # src/main/java/roomescape/SpringConfig.java # src/main/java/roomescape/controller/ReservationController.java # src/main/resources/application.properties # src/main/resources/schema.sql # src/test/java/roomescape/MissionStepTest.java
nova0128
reviewed
May 28, 2024
| try { | ||
| jdbcTemplate.update(sql, id); | ||
| } catch (DataAccessException e) { | ||
| throw new ReservationExceptionHandler.NoReservationException("존재하지 않는 시간입니다."); |
There was a problem hiding this comment.
시간에 대한 예외 처리를 다루는 클래스를 따로 만드는 게 더 좋을 것 같아요!
| @@ -0,0 +1,7 @@ | |||
| package roomescape.domain.dto; | |||
| return new ResponseTime(id, requestTime.time()); | ||
| } | ||
|
|
||
| public List<ResponseTime> findAll() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 리뷰어님 개인 사정으로 현재 step 9까지만 진행된 상태로 step 10이 완료되면 다시 말씀드리겠습니다..!
최대한 빠르게 완료해보도록 하겠습니다 죄송합니다..!
커밋 범위 : step 8
커밋 범위 : step 9 ~ step 10