Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring JDBC] 주병주 미션 제출합니다. #256

Open
wants to merge 6 commits into
base: gotobill
Choose a base branch
from

Conversation

GoToBILL
Copy link

@GoToBILL GoToBILL commented May 21, 2024

원래의 코드에서 변형하는 줄 알고 새로 풀리퀘를 안했었습니다. 죄송합니다

✅ 5, 6 ,7 단계 구현했습니다.
잘못된 점이나 보기 힘든 점 말씀해 주세요!


@Override
public List<Reservation> findAll() {
String sql = "select * from reservation";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
String sql = "select * from reservation";
String sql = "SELECT * FROM reservation";

다른 코드들처럼 대문자로 통일하면 보기 편할 거 같아요!

Copy link

@nyeroni nyeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 코드들은 다 깔끔하게 작성해주신 거 같습니다!!
수고하셨습니다 ~!

Copy link

@nyeroni nyeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants