Use actual width -- not potentially overridden width -- on smallest artboard #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug with the logic that automatically displays the narrowest artboard when the graphic is displayed at an even narrower width. If the smallest artboard's width is say 300px, but the artboard's name sets its min-width to 280px (using the :MIN_WIDTH artboard name syntax), the previous logic would set an inline CSS style of max-width to 280px. This PR fixes that by adjusting the getArtboardWidthRange() function to -- for the smallest artboard -- set the width range to [0, actualWidth] rather than the potentially overridden width. Since the actual width of the artboard in this example is 300px, the inline CSS style becomes max-width: 300px as expected. Please let me know if this explanation is unclear, and I can create and send an example .ai file and the output with and without this bugfix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug with the logic that automatically displays the narrowest
artboard when the graphic is displayed at an even narrower width.
If the smallest artboard's width is say 300px, but the artboard's name
sets its min-width to 280px (using the :MIN_WIDTH artboard name syntax),
the previous logic would set an inline CSS style of max-width to 280px.
This PR fixes that by adjusting the getArtboardWidthRange() function to
-- for the smallest artboard -- set the width range to [0, actualWidth]
rather than the potentially overridden width. Since the actual width of
the artboard in this example is 300px, the inline CSS style becomes
max-width: 300px as expected.
Please let me know if this explanation is unclear, and I can create and
send an example .ai file and the output with and without this bugfix.