Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: phoenix nil attribute #481

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix: phoenix nil attribute #481

merged 1 commit into from
Jan 14, 2025

Conversation

binaryseed
Copy link
Collaborator

Don't inspect the phoenix.view attribute unless it's present (so we don't send up "nil" as the value)

@binaryseed binaryseed requested a review from tpitale January 13, 2025 19:34
@binaryseed binaryseed mentioned this pull request Jan 13, 2025
Merged
19 tasks
@tpitale tpitale merged commit 10adb50 into master Jan 14, 2025
11 checks passed
@tpitale tpitale deleted the vince/fix-phoenix-attr branch January 14, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpitale tpitale tpitale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@binaryseed @tpitale