Merge pull request #480 from newrelic/vince/fix-bandit-resp_duration

Fix: bandit attributes
newrelic · Jan 14, 2025 · aa725f2 · aa725f2
2 parents 10adb50 + bad8dc8
commit aa725f2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/examples/apps/phx_example/test/phx_example_test.exs b/examples/apps/phx_example/test/phx_example_test.exs
@@ -23,6 +23,10 @@ defmodule PhxExampleTest do
 
         [[_, event]] = TestSupport.gather_harvest(Collector.TransactionEvent.Harvester)
 
+        if event[:"bandit.resp_duration_ms"] do
+          assert event[:"bandit.resp_duration_ms"] > 0
+        end
+
         assert event[:"phoenix.endpoint"] =~ "PhxExampleWeb"
         assert event[:"phoenix.router"] == "PhxExampleWeb.Router"
         assert event[:"phoenix.controller"] == "PhxExampleWeb.PageController"

diff --git a/lib/new_relic/telemetry/plug.ex b/lib/new_relic/telemetry/plug.ex
@@ -209,14 +209,10 @@ defmodule NewRelic.Telemetry.Plug do
 
   defp add_stop_attrs(meas, meta, :bandit) do
     info = Process.info(self(), [:memory, :reductions])
-    duration = meas[:duration] || System.monotonic_time() - meas[:monotonic_time]
-
-    resp_duration_ms =
-      meas[:resp_start_time] &&
-        (meas[:resp_start_time] |> to_ms) - (meas[:resp_end_time] |> to_ms)
+    resp_duration_ms = meas[:resp_start_time] && to_ms(meas[:resp_end_time]) - to_ms(meas[:resp_start_time])
 
     [
-      duration: duration,
+      duration: meas[:duration] || 0,
       status: status_code(meta) || 500,
       memory_kb: info[:memory] / @kb,
       reductions: info[:reductions],