Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to numpy v2 #56

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Update to numpy v2 #56

merged 2 commits into from
Nov 18, 2024

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Nov 15, 2024

Numpy is moved to v2 and the code is updated. The recipe and environment reflect this new requirement. This also turns on ruff rules for numpy checks. It is somewhat surprising how little needed to be changed.

Includes an unrelated update to the README about pre-commit which was missed previously.

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

This also turns on ruff rules for numpy checks
@peterfpeterson peterfpeterson marked this pull request as ready for review November 15, 2024 15:50
@Kvieta1990 Kvieta1990 merged commit 7b5492d into master Nov 18, 2024
2 checks passed
@Kvieta1990 Kvieta1990 deleted the numpy_v2 branch November 18, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants