Create Login #2
Merged
Create Login #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
mpatrou
reviewed
Apr 25, 2024
src/pyoncatqt/login.py
Outdated
| self.client_id = get_data("login.oncat", f"{key}_id") | ||
| if not self.client_id: | ||
| raise ValueError(f"Invalid key: {key}, ONCat client ID not found") | ||
| return |
mpatrou
reviewed
Apr 25, 2024
src/pyoncatqt/login.py
Outdated
| self.oncat_url = get_data("login.oncat", "oncat_url") | ||
| self.client_id = get_data("login.oncat", f"{key}_id") | ||
| if not self.client_id: | ||
| raise ValueError(f"Invalid key: {key}, ONCat client ID not found") |
There was a problem hiding this comment.
Can you put a more descriptive message: e.g. Invalid module {key}. No OnCat client Id is found for this application.
mpatrou
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes:
This creates the Login Dialog and a Login widget that can be used in other neutrons projects to provide a simple interface for logging in to ONCat.
Read the docs page
Manual test for the reviewer
Test out the widget and dialog with the following commands.
References
Relates to EWM #4464