Conda Package Build Process #154
Conversation
…conda build tools
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #154 +/- ##
=======================================
Coverage 88.79% 88.79%
=======================================
Files 23 23
Lines 1392 1392
=======================================
Hits 1236 1236
Misses 156 156 ☔ View full report in Codecov by Sentry. |
.github/workflows/unittest.yml
Outdated
| shell: bash -l {0} | ||
| run: | | ||
| python -m build --wheel --no-isolation | ||
| check-wheel-contents dist/multiphonon-*.whl | ||
| - name: Upload python wheel |
There was a problem hiding this comment.
Can you add a comment about this uploading as an artifact to the source repository rather than pypi/conda/whatever. It took me a bit to realize that and it'd be good to prevent misunderstandings.
pyproject.toml
Outdated
| @@ -18,8 +18,8 @@ requires = [ | |||
| "wheel", | |||
| "toml", | |||
| "versioningit", | |||
| "numpy == 1.20.3", | |||
| "scipy == 1.9.0" | |||
| "numpy >= 1.20.3", | |||
There was a problem hiding this comment.
This should probably be >1.20<2.0 to prevent accidentally moving forward. It shouldn't be an issue with mantid being involved.
pyproject.toml
Outdated
| "numpy == 1.20.3", | ||
| "scipy == 1.9.0" | ||
| "numpy >= 1.20.3", | ||
| "scipy >= 1.9.0" |
There was a problem hiding this comment.
It sounded like there was a maximum version of scipy too
conda.recipe/bld.bat
Outdated
There was a problem hiding this comment.
Shouldn't this be deleted?
conda.recipe/run-build.sh
Outdated
There was a problem hiding this comment.
This file should be removed
.github/workflows/unittest.yml
Outdated
There was a problem hiding this comment.
It might be better to rename this workflow.yml since it does a lot more than build and run the unit tests.
Related: Is CI.yml still active? It is unclear what these two workflows do.
There was a problem hiding this comment.
CI.yml is inactive. I would suggest to keep us a reference until the dependecy package issue is resolved. Then we delete it.
|
conda install noarch/multiphonon-0.2.0.dev26-py310.tar.bz2 |
Conda package creation process with conda_environment.yml, due to package dependency issues
(related to EWM5115)
Short description of the changes:
Updates include:
Long description of the changes:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References