-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add expiration field to DataRun model #25
Conversation
for more information, see https://pre-commit.ci
…er into expiration-field
for more information, see https://pre-commit.ci
…er into expiration-field
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #25 +/- ##
==========================================
- Coverage 86.87% 86.75% -0.13%
==========================================
Files 10 12 +2
Lines 282 317 +35
==========================================
+ Hits 245 275 +30
- Misses 37 42 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please change the relative imports back to absolute, mostly for clarity and consistency?
Short description of the changes:
Add
expiration_date
field toDataRun
model in order to flag for occasional deletion after some amount of time (3 years by default, can adjust later)Long description of the changes:
expiration_date
field toDataRun
purge_expired_data
admin commandexpiration_date
(as a python datetime) inupload_plot_data
andupload_user_data
endpointsget_or_create_run()
helper function, as well asstore_user/plot_data
get_all_runs
endpoint for utility, which includesexpiration_date
andexpired
(bool) fieldsAdditionally:
dependabot.yml
to check for updates to actions.gitignore
make clean
targetCheck list for the pull request
Check list for the reviewer
Manual test for the reviewer
References
EWM Story 4887