Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate Q-beam (Q-ki) #44

Merged
merged 8 commits into from
Feb 19, 2025
Merged

Calculate Q-beam (Q-ki) #44

merged 8 commits into from
Feb 19, 2025

Conversation

KyleQianliMa
Copy link
Collaborator

@KyleQianliMa KyleQianliMa commented Feb 17, 2025

Short description of the changes:

Implement calculations of the angle between Q-beam in the model. Added a quick hand sketch to demonstrate the calculations in the scripts folder.
EWM 9411.
To test, it may be easier to pull in draft PR#45 or branch "disaplayQbeamang" which implements the display that allows visual inspection of the calculated angles.

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@KyleQianliMa KyleQianliMa marked this pull request as draft February 17, 2025 16:29
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (75dbd9c) to head (f680269).

Additional details and impacted files
@@            Coverage Diff             @@
##             next      #44      +/-   ##
==========================================
+ Coverage   98.51%   98.53%   +0.01%     
==========================================
  Files          10       10              
  Lines         809      819      +10     
==========================================
+ Hits          797      807      +10     
  Misses         12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KyleQianliMa KyleQianliMa marked this pull request as ready for review February 19, 2025 18:10
@AndreiSavici AndreiSavici merged commit e0e8bea into next Feb 19, 2025
3 checks passed
@AndreiSavici AndreiSavici deleted the addQbeamang branch February 19, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants