Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadThedocs - Design and Code updates #41

Merged
merged 7 commits into from
Feb 13, 2025
Merged

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Feb 7, 2025

This includes updates mainly in the technical documentation files (docs/)

Short description of the changes:

Long description of the changes:

  • class and module signatures added
  • class connectivity, their parameters, in the diagrams updated
  • MVP workflow diagrams updates
  • documentation includes clean variables for future inclusion in the code to improve readbility
  • docstrings of various functions in MVP files updated to be included in the documentation
  • cleanup

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

Update documentation - design docs

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (c219107) to head (665e0e4).

Additional details and impacted files
@@           Coverage Diff           @@
##             next      #41   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files          10       10           
  Lines         806      807    +1     
=======================================
+ Hits          794      795    +1     
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpatrou mpatrou requested a review from AndreiSavici February 12, 2025 20:53
@AndreiSavici AndreiSavici merged commit 46b75c1 into next Feb 13, 2025
3 checks passed
@AndreiSavici AndreiSavici deleted the design_docs_updates branch February 13, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants