Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create HYSPEC intensity matrix #24

Merged
merged 23 commits into from
Jan 19, 2025
Merged

create HYSPEC intensity matrix #24

merged 23 commits into from
Jan 19, 2025

Conversation

KyleQianliMa
Copy link
Collaborator

@KyleQianliMa KyleQianliMa commented Jan 13, 2025

Short description of the changes:

EWM Story 8621

This PR calculates the powder intensity matrix for HyspecPPT. It considers S2 on either side of the detector and contains init, setter and getter functions for related models.

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

All tests should pass using pytest

References

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (f7b5f76) to head (6e8f5b3).

Additional details and impacted files
@@            Coverage Diff             @@
##             next      #24      +/-   ##
==========================================
+ Coverage   92.90%   98.36%   +5.45%     
==========================================
  Files          10       10              
  Lines         747      732      -15     
==========================================
+ Hits          694      720      +26     
+ Misses         53       12      -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AndreiSavici AndreiSavici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable

@KyleQianliMa KyleQianliMa merged commit 2afde0f into next Jan 19, 2025
3 checks passed
@KyleQianliMa KyleQianliMa deleted the powder_model branch January 19, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants