Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre commit #607

Open
wants to merge 15 commits into
base: next
Choose a base branch
from
Open

Update pre commit #607

wants to merge 15 commits into from

Conversation

backmari
Copy link
Contributor

@backmari backmari commented Dec 18, 2024

Short description of the changes:

  • Update .pre-commit-config.yaml and pyproject.toml to ignore notebooks
  • Switch to ruff format to be in line with neutrons python project template
  • run ruff formatting
  • manually address lint errors or add noqa: comments where sensible to avoid changing functioning logic too much

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • [n/a] I have added tests for my changes
  • [n/a] I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants