Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Artemis Data Collector and display queue lengths #203

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Dec 6, 2024

Description of the changes

8459: Update WebMon to display data added by the Artemis Data Collector app

Adds https://github.com/neutrons/artemis_data_collector to the docker compose so it can be tested.

If you go to http://localhost/dasmon/common/diagnostics/ you should see the new table

One way to test is to stop the autoreducer container and run a system test causing runs to be added to the queue without being consumed. e.g.

docker stop data_workflow-autoreducer-1
python -m pytest tests

the test will fail but now you should see

2024-12-06-114911_418x103_scrot

You can also look at the database entries at http://localhost/database/report/statusqueuemessagecount/

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.86%. Comparing base (462ed48) to head (07a80d8).

Files with missing lines Patch % Lines
...rc/workflow_app/workflow/database/report/models.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #203      +/-   ##
==========================================
+ Coverage   77.78%   77.86%   +0.07%     
==========================================
  Files          54       54              
  Lines        4709     4730      +21     
==========================================
+ Hits         3663     3683      +20     
- Misses       1046     1047       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosswhitfield rosswhitfield marked this pull request as ready for review December 6, 2024 04:20
@backmari
Copy link
Contributor

backmari commented Dec 6, 2024

Looks good! I tested according to the manual test instructions and I see the queue lengths as expected
image

@rosswhitfield rosswhitfield merged commit 807b4a1 into next Dec 8, 2024
4 checks passed
@rosswhitfield rosswhitfield deleted the queue_message_count branch December 8, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants