Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency graph #180

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Update dependency graph #180

merged 4 commits into from
Sep 5, 2024

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Sep 5, 2024

Replaced the obsolete services dependency graph with a new local deployment dependency graph. Modified docker-compose dependencies by removing conditions on the db and webmon services for streamlined startup.

Description of the changes

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Replaced the obsolete services dependency graph with a new local deployment dependency graph. Modified docker-compose dependencies by removing conditions on the db and webmon services for streamlined startup.

Signed-off-by: Jose Borreguero <[email protected]>
@jmborr jmborr self-assigned this Sep 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.10%. Comparing base (e98f787) to head (0ad3360).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #180   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files          50       50           
  Lines        4626     4626           
=======================================
  Hits         3567     3567           
  Misses       1059     1059           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Repositioned `webmonchow` to a different section and added a new dependency link from `webmonchow` to `webmon`. This improves the clarity of the module interactions and reflects recent architecture changes.

Signed-off-by: Jose Borreguero <[email protected]>
@jmborr jmborr changed the title Update dependency graph and docker-compose conditions Update dependency graph Sep 5, 2024
Clarify dependency relationships and add a diagram in build.rst. This ensures a clear understanding of service dependencies for local deployment, aiding both unit and system tests.

Signed-off-by: Jose Borreguero <[email protected]>
@jmborr jmborr merged commit 88f13a1 into next Sep 5, 2024
4 checks passed
@jmborr jmborr deleted the dependency_graph branch September 5, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants