Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dockerfile.autoreducer.himem and update configurations #179

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Aug 30, 2024

Description of the changes

Deleted Dockerfile.autoreducer.himem and refactored docker-compose.yml to use Dockerfile.autoreducer for both standard and high memory configurations. Updated Dockerfile.webmonchow to install webmonchow version 1.0.1 for improved stability.

Check all that apply:

  • updated documentation
  • Source added/refactored~~
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items: 7035

Manual test for the reviewer

Install the local deployment

make clean
make all
make locadev/up

Enter container data_workflow-feature-autoreducer_himem-1 and verify that file /etc/autoreduce/post_processing.conf in this container corresponds to file tests/configuration/post_process_consumer.himem.conf in the repo

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Deleted Dockerfile.autoreducer.himem and refactored docker-compose.yml to use Dockerfile.autoreducer for both standard and high memory configurations. Updated Dockerfile.webmonchow to install webmonchow version 1.0.1 for improved stability and features.

Signed-off-by: Jose Borreguero <[email protected]>
@jmborr jmborr requested a review from backmari August 30, 2024 19:21
@jmborr jmborr self-assigned this Aug 30, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.10%. Comparing base (da38a73) to head (9149c43).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #179   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files          50       50           
  Lines        4626     4626           
=======================================
  Hits         3567     3567           
  Misses       1059     1059           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmborr jmborr merged commit e98f787 into next Sep 3, 2024
4 checks passed
@jmborr jmborr deleted the single_autoreducer_dockerfile branch September 3, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants