Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce webmonchow #176

Merged
merged 15 commits into from
Aug 27, 2024
Merged

Introduce webmonchow #176

merged 15 commits into from
Aug 27, 2024

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Aug 27, 2024

Description of the changes

Substitute services amq_test_gen and amq_pv_gen with service webmonchow, and update the documentation.

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items: 5986
  • Links to related issues or pull requests:

Manual test for the reviewer

Deploy locally and verify the web monitor works

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

jmborr added 15 commits August 23, 2024 17:02
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Replaced the AMQ and PV generator services with the unified webmonchow service. Updated Dockerfiles, Docker Compose, and documentation to reflect this change, simplifying the deployment and maintenance process.

Signed-off-by: Jose Borreguero <[email protected]>
Upgraded Miniconda from 4.12.0 to 23.3.1-0 and revised webmonchow installation. Added health check for ActiveMQ in docker-compose to enhance service reliability.

Signed-off-by: Jose Borreguero <[email protected]>
@jmborr jmborr requested a review from backmari August 27, 2024 02:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.10%. Comparing base (c59e7a3) to head (5f3a7a4).
Report is 5 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #176   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files          50       50           
  Lines        4626     4626           
=======================================
  Hits         3567     3567           
  Misses       1059     1059           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR replaces two docker containers used by the system tests Dockerfile.amq_test_gen and Dockerfile.pv_test_gen with the new test fixture container defined in Dockerfile.webmonchow.
I can stand up the local developer environment from the docker-compose.yml and WebMon works as expected. The PV:s are updated for ARCS, HYSA and REF_M and the status of DASMON is green for the instruments.
I was able to change the templated autoreduction configuration for REF_M at http://localhost/reduction/ref_m/ and the parameter changes were reflected in the autoreduction script in the autoreducer container.

@jmborr jmborr merged commit 8409e9c into next Aug 27, 2024
4 checks passed
@jmborr jmborr deleted the introduce_webmonchow branch August 27, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants