-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce webmonchow #176
Introduce webmonchow #176
Conversation
Signed-off-by: Jose Borreguero <[email protected]>
…tings Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
Replaced the AMQ and PV generator services with the unified webmonchow service. Updated Dockerfiles, Docker Compose, and documentation to reflect this change, simplifying the deployment and maintenance process. Signed-off-by: Jose Borreguero <[email protected]>
Upgraded Miniconda from 4.12.0 to 23.3.1-0 and revised webmonchow installation. Added health check for ActiveMQ in docker-compose to enhance service reliability. Signed-off-by: Jose Borreguero <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #176 +/- ##
=======================================
Coverage 77.10% 77.10%
=======================================
Files 50 50
Lines 4626 4626
=======================================
Hits 3567 3567
Misses 1059 1059 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR replaces two docker containers used by the system tests Dockerfile.amq_test_gen
and Dockerfile.pv_test_gen
with the new test fixture container defined in Dockerfile.webmonchow
.
I can stand up the local developer environment from the docker-compose.yml
and WebMon works as expected. The PV:s are updated for ARCS, HYSA and REF_M and the status of DASMON is green for the instruments.
I was able to change the templated autoreduction configuration for REF_M at http://localhost/reduction/ref_m/
and the parameter changes were reflected in the autoreduction script in the autoreducer container.
Description of the changes
Substitute services
amq_test_gen
andamq_pv_gen
with servicewebmonchow
, and update the documentation.Check all that apply:
Added unit testsAdded integration tests(If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without failReferences:
Manual test for the reviewer
Deploy locally and verify the web monitor works
Check list for the reviewer