Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added presentations #172

Merged
merged 1 commit into from
Aug 16, 2024
Merged

added presentations #172

merged 1 commit into from
Aug 16, 2024

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Aug 16, 2024

Description of the changes

insert a bunch of presentations with links to PDF and PPTX

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

Manual test for the reviewer

conda activate webmon
cd docs/
make html

Then verify that data_workflow/data_workflow-review/docs/_build/html/developer/index.html contains links to the presentations, like this

capture

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Signed-off-by: Jose Borreguero <[email protected]>
@jmborr jmborr requested a review from backmari August 16, 2024 16:32
@jmborr jmborr self-assigned this Aug 16, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.10%. Comparing base (c59e7a3) to head (7a43cb8).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #172   +/-   ##
=======================================
  Coverage   77.10%   77.10%           
=======================================
  Files          50       50           
  Lines        4626     4626           
=======================================
  Hits         3567     3567           
  Misses       1059     1059           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@backmari
Copy link
Contributor

Nice to have these presentations available in the documentation 👌
I ran the manual test and the presentations show up in the documentation as expected.
image

@jmborr jmborr merged commit 2c64eef into next Aug 16, 2024
4 checks passed
@jmborr jmborr deleted the add_presentions branch August 16, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants