-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add systemtest for livedata/postprocessing interaction #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rosswhitfield @backmari can we move from the current scheme of incorporating the date to the image tag to the image tagging scheme of the livedata repo?
@rosswhitfield Upon composing the images in the local environment, the build process complains of missing set variables.
Perhap that's why the containers are unhealthy:
Are you setting these variables using the values from the secret CI variables stored in the webmon-deploy repo? |
Sorry, it looks like the dev docs need updating. Do this first before running docker and the tests
You don't need to set the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #167 +/- ##
=======================================
Coverage 77.07% 77.07%
=======================================
Files 50 50
Lines 4616 4616
=======================================
Hits 3558 3558
Misses 1058 1058 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref: 5723: LiveDataServer: Add testing in WebMon test environment
This adds the livedata container to docker-compose, webmon assume it has ssl so a self-signed ssl cert is created and used for access to livedata. I set a static IP for the nginx container so that it can be accessed consistently from with the docker network and outside.
A systemtest was added that triggers the new data files request, this causes the autoreduction to run with was updated to publish a "plot" to livedata. The data is then verify that it can be accessed from webmon/outside.
You can manually test the interactions. First
make clean
andmake all
then start up docker-compose,docker-compose up --build
. After which you can access webmon via http://localhost . You will need to visit livedata once by https://172.16.238.222/ and "accept" the self-signed cert (Proceed unsafe) for this to work.After visit http://localhost/report/arcs/214583/ and you should see the "Example Plot Data" (which is just text).
You can then select "reduction" at the bottom of the page then wait, after a while the "plot data" will update and you should see a new timestamp. This verifies that autoreduction is correctly publishing to livedata.
This should work for any ARCS run
Short description of the changes:
Long description of the changes:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References