REF_M: Add the capability to autoreduce two samples from the same run #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Borreguero <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #166 +/- ##
==========================================
+ Coverage 77.07% 77.16% +0.08%
==========================================
Files 50 50
Lines 4616 4634 +18
==========================================
+ Hits 3558 3576 +18
Misses 1058 1058 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Jose Borreguero <[email protected]>
jmborr
force-pushed
the
refm_multi_samples
branch
from
a27a83a to
cd936e0
Compare
for more information, see https://pre-commit.ci
backmari
previously approved these changes
Jun 25, 2024
There was a problem hiding this comment.
I ran the manual test and could see the REF_M configuration form with parameters added to accommodate up to three samples according to the requirements by the instrument scientists. Unit tests have been modified to verify the new form fields. Looks good to me.
Signed-off-by: Jose Borreguero <[email protected]>
backmari
approved these changes
Aug 6, 2024
backmari
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References EWM 5797
Short description of the changes:
Update the reduction options form for instrument
REF_Mwith entries for up to three samples.Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
Run unit test
test_ref_mbut first remove comment to print the HTML form. After that point your browser tofile:///tmp/junk.htmlto see the form with entries for three samples.