Highlighting master table columns #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshallmcdonnell
requested changes
Apr 16, 2019
There was a problem hiding this comment.
If I change an entry in the column that is already cyan (all rows match), I get the following where that single select cell is cyan. Do you get this as well? Hope it is not OS specific:
Similarly, if I go to a white column, change one row such that they are all the same, the selected cell stays white:
This reverts commit 1163b46.
… when checking for same values in column. This refs #231
|
Looking great now, new changes fix the highlighting bug! If flake8 issues brought up in CI are fixed, this is good to go. |
marshallmcdonnell
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the work has been done as part of #134 .
To test this PR,