Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oncat connectivity status +configuration mechanism #146

Merged
merged 6 commits into from
Jan 24, 2025

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Jan 17, 2025

Short description of the changes:

related PR: neutrons/pyoncatqt#9
oncat connectivity status logic update, configuration mechanism and client id

Long description of the changes:

The code includes the following:

  • oncat connectivity status appears only for 5 seconds
  • ocan login dialog pops up at button pressing at any time
  • client id update
  • configuration mechanism with inclusion of version. Version is retrieved from _version_ and written to the user's configuration file. If user's version does not exist or different that current software version all configruation variables are updated, else it works as before.
  • tests updated/new for the logic
  • refine ub update with group attribute, due to Mantid changes

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

[SHIVER] OnCat -  Connection Status functionality update

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.33%. Comparing base (f490bdd) to head (6edcab3).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #146      +/-   ##
==========================================
+ Coverage   82.29%   82.33%   +0.03%     
==========================================
  Files          39       39              
  Lines        6195     6209      +14     
==========================================
+ Hits         5098     5112      +14     
  Misses       1097     1097              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpatrou mpatrou merged commit 8215db3 into next Jan 24, 2025
6 checks passed
@mpatrou mpatrou deleted the oncat_connection_status branch January 24, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants