Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ewm4911 reduction integration tests #545

Merged
merged 7 commits into from
Feb 19, 2025

Conversation

dlcaballero16
Copy link
Collaborator

@dlcaballero16 dlcaballero16 commented Feb 14, 2025

PR for changes to snapred-data repo: https://code.ornl.gov/sns-hfir-scse/infrastructure/test-data/snapred-data/-/merge_requests/5

Description of work

Added regression tests specifically for the reduction workflow.

Explanation of work

Test was added to test a bunch of different cases the reduction tab can go through.

To test

Dev testing

Run all the integration tests locally, or make sure the runner passes. If running locally, make sure your test data repo is pointing to the correct branch, should be changes-for-reduction-testing.

CIS testing

None.

Link to EWM item

EWM#4911

Verification

  • the author has read the EWM story and acceptance critera
  • the reviewer has read the EWM story and acceptance criteria
  • the reviewer certifies the acceptance criteria below reflect the criteria in EWM

Acceptance Criteria

This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.

  • Look at the story description and make sure the test follows all of the steps

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (c5e5379) to head (19ca66e).
Report is 2 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #545   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files          71       71           
  Lines        5463     5463           
=======================================
  Hits         5246     5246           
  Misses        217      217           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darshdinger
Copy link
Contributor

Code looks good. Only consideration would be to update this code later on to employ qtbot.waitUntil rather than qtbot.wait(someTime) would help mitigate some of the segmentation faults that might be occurring.

All tests pass:
image

@dlcaballero16 dlcaballero16 merged commit 24a4b0d into next Feb 19, 2025
8 checks passed
@dlcaballero16 dlcaballero16 deleted the ewm4911_reduction_integration_tests branch February 19, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants