-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ewm 5538 normalization regression tests #531
Open
dlcaballero16
wants to merge
9
commits into
next
Choose a base branch
from
ewm-5538-normalization-regression-tests
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logarithmic slider, attempt to create mock object when patching warning box
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #531 +/- ##
===========================================
- Coverage 95.77% 48.56% -47.22%
===========================================
Files 68 68
Lines 5091 5090 -1
===========================================
- Hits 4876 2472 -2404
- Misses 215 2618 +2403 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This adds regression tests specifically for the normalization workflow. This tests a bunch of failure cases and makes sure normalization runs correctly.
Explanation of work
This test is based on the normalization happy paths test. This test makes sure that intended failures have the correct warning message when failing, and that the final output of normalization is correct. TestSummary was also moved into its own class so that it can be reused within the normalization test.
To test
Dev testing
Run the test locally, or just make sure the integration test step passes.
CIS testing
None, this for internal testing.
Link to EWM item
EWM#5538
Verification
Acceptance Criteria
This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.