Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ewm 5538 normalization regression tests #531

Open
wants to merge 9 commits into
base: next
Choose a base branch
from

Conversation

dlcaballero16
Copy link
Collaborator

Description of work

This adds regression tests specifically for the normalization workflow. This tests a bunch of failure cases and makes sure normalization runs correctly.

Explanation of work

This test is based on the normalization happy paths test. This test makes sure that intended failures have the correct warning message when failing, and that the final output of normalization is correct. TestSummary was also moved into its own class so that it can be reused within the normalization test.

To test

Dev testing

Run the test locally, or just make sure the integration test step passes.

CIS testing

None, this for internal testing.

Link to EWM item

EWM#5538

Verification

  • the author has read the EWM story and acceptance critera
  • the reviewer has read the EWM story and acceptance criteria
  • the reviewer certifies the acceptance criteria below reflect the criteria in EWM

Acceptance Criteria

This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.

  • There's a lot of steps, just verify this test is handling every case listed in the EWM description

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.56%. Comparing base (9c3f01d) to head (125d368).

Files with missing lines Patch % Lines
src/snapred/backend/service/CalibrationService.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (9c3f01d) and HEAD (125d368). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (9c3f01d) HEAD (125d368)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             next     #531       +/-   ##
===========================================
- Coverage   95.77%   48.56%   -47.22%     
===========================================
  Files          68       68               
  Lines        5091     5090        -1     
===========================================
- Hits         4876     2472     -2404     
- Misses        215     2618     +2403     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlcaballero16 dlcaballero16 marked this pull request as ready for review January 15, 2025 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant