Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter from Nexus to ORSO.ort for autoreduced files #25

Open
wants to merge 13 commits into
base: next
Choose a base branch
from

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Jan 13, 2025

Description of work:

Check all that apply:

  • added release notes
    (if not, provide an explanation in the work description)
  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests

References:

  • Links to IBM EWM items: 8865

Manual test for the reviewer

Install in editable mode (pip install -e ./) so that you can run script nexus_to_orso :

cd /path/to/MagnetismReflectometer/mr_reduction-feature/tests/mr_reduction-data/
nexus_to_orso --nexus REF_M_42535_1_Off_Off_autoreduce.nxs.h5 --ort /tmp/REF_M_42535_1_Off_Off_autoreduce.ort

The resulting file should be loadable in refl1d

Check list for the reviewer

  • release notes
    updated, or an explanation is provided as to why release notes are unnecessary
  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date

@jmborr jmborr self-assigned this Jan 13, 2025
Signed-off-by: Jose Borreguero <[email protected]>
Signed-off-by: Jose Borreguero <[email protected]>
The time stamp changes with the test

Signed-off-by: Jose Borreguero <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 96.60194% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.22%. Comparing base (6c10df9) to head (715277d).

Files with missing lines Patch % Lines
src/mr_reduction/io_orso.py 90.19% 5 Missing ⚠️
src/mr_reduction/beam_options.py 98.43% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next      #25      +/-   ##
==========================================
+ Coverage   77.65%   78.22%   +0.56%     
==========================================
  Files          19       21       +2     
  Lines        2278     2360      +82     
==========================================
+ Hits         1769     1846      +77     
- Misses        509      514       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmborr jmborr requested a review from glass-ships January 14, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants