-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add new ECG delineator method: Peak-Prominence (Emrich et al., 2024) #1053
[Feature] Add new ECG delineator method: Peak-Prominence (Emrich et al., 2024) #1053
Conversation
Amazing, thanks a lot! |
Co-authored-by: Dominique Makowski <[email protected]>
For processing a 30-minute single-lead ECG on a Ryzen 7 1800X, the median runtime was: DWT at 9.86 ± 1.07 s, Peak at 11.86 ± 1.83 s, and Prominence at 1.36 ± 0.75 s (excluding R-peak detection and measuring only the time of delineation). Detection performance is always dependent on the data and evaluation criteria. Using the standard evaluation procedure from the literature (measuring the averaged min-errors over all leads), the prominence-based delineator achieved better F1-scores and lower error variability. When combining multiple leads a further performance gain can be expected. |
Co-authored-by: Dominique Makowski <[email protected]>
Interesting, thanks. Please don't hesitate to let me know in the future - once maybe you gather even more evidence in favour of its superiority - if you think it should become the new default (assuming it is indeed an overall improvement for most use-cases) Related, maybe we could add in the docstrings a sentence or two to help the user pick the method. Like e.g., "The prominence method might be useful to detect the waves, but the peak method might be more precise for detecting the onsets/offsets of the waves (but is very sensitive to signal quality and noise)" what do you think? |
Great Idea! I tried to make a fitting suggestion |
Sweet, thanks again @JonasEmrich, I think we're good to go 🚀 |
Description
This PR adds the
prominence
delineator to theecg_delineate
method. The prominence delineator tries to achieve a robust and interpretable wave detection by building upon peak prominence and physiology-based search windows. [1]Checklist
[1] J. Emrich, A. Gargano, T. Koka and M. Muma, "Physiology-Informed ECG Delineation Based on Peak Prominence," 2024 32nd European Signal Processing Conference (EUSIPCO), Lyon, France, 2024, pp. 1402-1406, doi: 10.23919/EUSIPCO63174.2024.10715353.