Fix last_checkpoint
#84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also I need to mention that my solution are not susceptible to this issue of recursively looping because it doesn't search in directories from symlink. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #84 +/- ##
==========================================
+ Coverage 80.86% 80.91% +0.04%
==========================================
Files 34 34
Lines 1270 1273 +3
Branches 255 256 +1
==========================================
+ Hits 1027 1030 +3
Misses 179 179
Partials 64 64 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request closes #80
The problem was there because following symlinks for
pathlib.Path.globwas disabled on purpose as a fix for this issue. Also now in case there is no checkpointslast_checkpointwill returnNone.After these commits it may be needed to edit tests accordingly.