Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #82

Merged
merged 49 commits into from
Apr 11, 2024
Merged

Dev #82

merged 49 commits into from
Apr 11, 2024

Conversation

arseniybelkov
Copy link
Member

@arseniybelkov arseniybelkov commented Feb 12, 2024

Features

Fixes

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.34%. Comparing base (acaadde) to head (417d41e).
Report is 8 commits behind head on master.

Files Patch % Lines
thunder/callbacks/metric_monitor.py 83.33% 2 Missing ⚠️
thunder/cli/main.py 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   81.02%   81.34%   +0.32%     
==========================================
  Files          34       34              
  Lines        1265     1276      +11     
  Branches      252      257       +5     
==========================================
+ Hits         1025     1038      +13     
+ Misses        177      175       -2     
  Partials       63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arseniybelkov arseniybelkov linked an issue Mar 8, 2024 that may be closed by this pull request
@arseniybelkov arseniybelkov linked an issue Mar 22, 2024 that may be closed by this pull request
@arseniybelkov arseniybelkov requested a review from maxme1 March 25, 2024 14:19
@arseniybelkov arseniybelkov merged commit 1ef613a into master Apr 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

group_metrics consume too much memory thunder run NAME does not fail when NAME does not exist
2 participants