Skip to content

Fix walk with validate when node is null #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025
Merged

Conversation

justin-tay
Copy link
Contributor

Closes #1167

Should not actually validate when walking with node that is null.

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.26%. Comparing base (48ca3c2) to head (b2aad39).
Report is 89 commits behind head on master.

Files with missing lines Patch % Lines
...c/main/java/com/networknt/schema/NotValidator.java 50.00% 0 Missing and 1 partial ⚠️
...main/java/com/networknt/schema/OneOfValidator.java 50.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1169      +/-   ##
============================================
- Coverage     78.90%   78.26%   -0.65%     
- Complexity     1965     2070     +105     
============================================
  Files           172      201      +29     
  Lines          6352     6855     +503     
  Branches       1255     1254       -1     
============================================
+ Hits           5012     5365     +353     
- Misses          867     1019     +152     
+ Partials        473      471       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevehu stevehu merged commit ffe4ca0 into networknt:master May 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation errors returned while walking anyOf and oneOf when node == null
3 participants