chore: remove non-envelope code paths and tests #6603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrstork
force-pushed
the
remove-envelope-checks
branch
from
369ba3b
to
3d183fb
Compare
jasonbarry
previously approved these changes
May 15, 2024
src/commands/dev/dev-exec.ts
Outdated
Comment on lines
12
to
13
| env = await getEnvelopeEnv({ api, context: options.context, env, siteInfo }) | ||
| env = await getDotEnvVariables({ devConfig: { ...config.dev }, env, site }) |
There was a problem hiding this comment.
The readability here was a bit confusing for me, considering that the consecutive lines re-assign to env. Maybe we can use new variable names, and const instead of let, now that there's no conditional?
There was a problem hiding this comment.
Addressed in 1e6343f
mrstork
force-pushed
the
remove-envelope-checks
branch
from
926c9ad
to
1e6343f
Compare
5 tasks
jasonbarry
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #5660
Fixes CT-1151
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.