Remove sensitive data from nethvoice #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephdl
force-pushed
the
sdl-7011
branch
7 times, most recently
from
8b55528
to
3276be5
Compare
stephdl
force-pushed
the
sdl-7011
branch
3 times, most recently
from
172351b
to
b4693e8
Compare
Stell0
approved these changes
Sep 26, 2024
Amygos
requested changes
Oct 1, 2024
| # start nethcti-server if wizard step is completed | ||
| WIZARD_STEP=$(/usr/bin/podman exec mariadb mysql -u root -h 127.0.0.1 -P $NETHVOICE_MARIADB_PORT -p$MARIADB_ROOT_PASSWORD asterisk -BNe "select step from rest_wizard" | tr -d -c '[:digit:]') | ||
| WIZARD_STEP=$(/usr/bin/podman exec --env-file=./passwords.env mariadb mysql -u root -h 127.0.0.1 -P $NETHVOICE_MARIADB_PORT -p$MARIADB_ROOT_PASSWORD asterisk -BNe "select step from rest_wizard" | tr -d -c '[:digit:]') |
There was a problem hiding this comment.
Are you sure the the $NETHVOICE_MARIADB_PORT and $MARIADB_ROOT_PASSWORD are expanded inside the container and not in the host?
…USER_PORTAL_USERNAME environment variable gracefully
stephdl
force-pushed
the
sdl-7011
branch
10 times, most recently
from
6f39134
to
51445f9
Compare
Amygos
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously random keys were stored in redis, now we use a passfile
passwords.envto store the keysThe relevant variables are
NethServer/dev#7011