-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 #133
V3 #133
Conversation
WorkflowRemediation removes some of the guesswork in how to use HConfig for building remediation and rollback configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's preserve the v2 documentation by creating a v2 folder and copying the original docs to the v2 folder. In the index, let's create a link to the v2 docs.
I created a 2.3-lts branch from master so that we can easily support bug fixes (if required) for a period of time until folks migrate.
Edit: It's unnecessary to create a a v2 version of the docs. They're available on readthedocs.io as is:
# Conflicts: # docs/v2.3/experimental-features.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉
Most notably, `lineage` has been renamed to `match_rules` where appropriate.
Numerous major enhancements to
HConfig
:add_child()
no longer takes an optional index. This feature was seldom used and the order weight functionality offers a similar capability.HConfig
.HConfig.logs
. This feature was seldom used and never fully implemented.HConfigChild.to_tag_spec()
. This feature was seldom used and can be implemented externally if needed.get_children()
has been extensively optimized for performance.HConfigBase._with_tags()
bug fix iftags.intersection(child.tags): -> if tags.issubset(child.tags):
HConfig
and config view constructor functions are now consolidated inconstructors.py
HConfig.add_children_deep()
text_match.py
HConfig
from str/DumpHConfig.all_children_sorted_with_lineage_rules()
. This feature was seldom used and can be implemented externally if needed.