Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support global prefix #1326

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

lit26
Copy link

@lit26 lit26 commented Mar 13, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #1280
Serve static can't handle globalprefix

What is the new behavior?

// main.ts
app.setGlobalPrefix('v1');
//app.module.ts
ServeStaticModule.forRoot({
      rootPath: join(__dirname, '..', 'client'),
      useGlobalPrefix: true,
}),

Will serve html on v1/

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

@codingholt codingholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@MeesPos
Copy link

MeesPos commented Apr 9, 2024

Can this be merged please? I need this asap!

@lit26
Copy link
Author

lit26 commented Apr 10, 2024

I don't have the permission to merge this.

@lit26 lit26 requested a review from micalevisk April 11, 2024 19:40
@lit26
Copy link
Author

lit26 commented May 5, 2024

Will this be merged soon? @micalevisk

@micalevisk
Copy link
Member

@lit26 There is no ETA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants