Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use PORT environment variable as default port #288

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BrunnerLivio
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #125

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@sinedied
Copy link

sinedied commented Jun 10, 2021

@BrunnerLivio Would it be possible to update this so that it can be merged?

@sinedied
Copy link

@micalevisk I have an up-to-date version of almost the same changes here, but an extra improvement: #672

I've credited @BrunnerLivio and he even said to go with my PR instead of this stale one, could you then reopen it?

@micalevisk
Copy link
Member

micalevisk commented Dec 17, 2021

@sinedied I cannot reopen PRs. Didn't saw that one. Looks better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants