Don't consume stderr in merge-squashfs
#736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of nerves-project/nerves#877 for adding more useful output during the firmware build process. nerves-project/nerves#876 shows cases where `mix firmware` fails to build. In reproducing, I found that `merge-squashfs` was failing silently. Specifically at this line because `2>/dev/null` was forwarding stderr to be ignored. Instead, this changes to let stderr through so more helpful messages can be reviewed
|
What's the error? My feeling is that redirecting stderr was don't on purpose. I agree that it shouldn't be redirected here, but I think that |
|
In this case - |
|
I ran it with a a few different successful builds and it does not seem to output anything (using |
|
Yes. Thanks!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of nerves-project/nerves#877 for adding more useful output during the firmware build process.
nerves-project/nerves#876 shows cases where
mix firmwarefails to build. In reproducing, I found thatmerge-squashfswas failing silently. Specifically at this line because2>/dev/nullwas forwarding stderr to be ignored.Instead, this changes to let stderr through so more helpful messages can be reviewed