Skip to content

PY-309 Fix order of values returned by fetch_multiple_series_values #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabrys merged 2 commits into from
Dec 1, 2025
Merged

PY-309 Fix order of values returned by fetch_multiple_series_values #135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1e8edb
PY-309 Fix order of values returned by `fetch_multiple_series_values`
gabrys Dec 1, 2025
cc75baf
Update metrics.py
gabrys Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/neptune_query/internal/retrieval/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ def fetch_multiple_series_values(
for request_id, run_attribute in request_id_to_attribute.items()
],
"stepRange": {"from": step_range[0], "to": step_range[1]},
"order": "ascending" if not tail_limit else "descending",
# Fetch in descending order to enable efficient tail fetching
"order": "descending",
}

results: dict[identifiers.RunAttributeDefinition, list[FloatPointValue]] = {
Expand All @@ -110,8 +111,11 @@ def fetch_multiple_series_values(
initial_params=params,
):
for attribute, values in page_result.items:
sorted_values = values if tail_limit else reversed(values)
results[attribute].extend(sorted_values)
results[attribute].extend(values)

# Reverse the order of values to maintain ascending order
for attribute in results:
results[attribute].reverse()

return results

Expand Down
Loading