Skip to content

PY-309 Fix order of values returned by fetch_series_values #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gabrys merged 6 commits into from
Dec 1, 2025
Merged

PY-309 Fix order of values returned by fetch_series_values #132

gabrys merged 6 commits into from
Dec 1, 2025

Conversation

@gabrys
Copy link
Contributor

@gabrys gabrys commented Nov 28, 2025

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@linear
Copy link

linear bot commented Nov 28, 2025

PY-309 Make fetch_series_values return values sorted by step, descending order

@gabrys gabrys force-pushed the gabrys/py-309-fix-order-in-fetch-series branch from af2e933 to d5ebc8a Compare November 28, 2025 12:03
@gabrys gabrys requested a review from pitercl November 28, 2025 12:10
@gabrys gabrys force-pushed the gabrys/py-309-fix-order-in-fetch-series branch from 0938d51 to 19cd842 Compare December 1, 2025 13:06
@gabrys gabrys force-pushed the gabrys/py-309-fix-order-in-fetch-series branch from 19cd842 to 338e485 Compare December 1, 2025 13:09
@gabrys gabrys force-pushed the gabrys/py-309-fix-order-in-fetch-series branch from 2b0ea73 to 06904ea Compare December 1, 2025 13:48
pitercl
pitercl reviewed Dec 1, 2025
View reviewed changes
src/neptune_query/internal/retrieval/series.py
params["perSeriesPointsLimit"] = tail_limit

yield from util.fetch_pages(
results: dict[RunAttributeDefinition, list[SeriesValue]] = {
Copy link
Member

@pitercl pitercl Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the function return an empty list for a series that backend doesn't have.

@gabrys gabrys added this pull request to the merge queue Dec 1, 2025
Merged via the queue into main with commit 932ff5e Dec 1, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitercl pitercl pitercl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gabrys @pitercl