Skip to content

Conversation

@SiddhantSadangi
Copy link
Member

Description

Updated GX example for GX Core 1.x

Related to: Fix GX OSS example

Any expected test failures?


Add a [X] to relevant checklist items

❔ This change

  • adds a new feature
  • fixes breaking code
  • is cosmetic (refactoring/reformatting)

✔️ Pre-merge checklist

  • Refactored code (sourcery)
  • Tested code locally
  • Precommit installed and run before pushing changes
  • Added code to GitHub tests (notebooks, scripts)
  • Updated GitHub README
  • Updated the projects overview page on Notion

🧪 Test Configuration

  • OS: Windows11
  • Python version: 3.10.11
  • Neptune version: 1.12.0
  • Affected libraries with version: great-expectations==1.1.3

@SiddhantSadangi SiddhantSadangi requested a review from a team October 22, 2024 13:45
@SiddhantSadangi SiddhantSadangi self-assigned this Oct 22, 2024
@SiddhantSadangi SiddhantSadangi requested a review from a team October 22, 2024 13:49
Copy link
Contributor

@szaganek szaganek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still OSS mentioned in 3 places (under Installation, Log Validation results, and upload HTML reports )

@SiddhantSadangi SiddhantSadangi merged commit a4b05f1 into main Oct 23, 2024
30 of 36 checks passed
@SiddhantSadangi SiddhantSadangi deleted the ss/gx branch October 23, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants