Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Django CMS version < 4 #787

Merged

Conversation

protoroto
Copy link
Member

Description

Pin Django CMS version < 4

References

Fix #786

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@protoroto protoroto requested a review from yakky January 9, 2024 07:57
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1bfa8ea) 94.38% compared to head (5e0126b) 94.38%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #787   +/-   ##
========================================
  Coverage    94.38%   94.38%           
========================================
  Files           26       26           
  Lines         1871     1871           
  Branches       266      266           
========================================
  Hits          1766     1766           
  Misses          53       53           
  Partials        52       52           
Flag Coverage Δ
unittests 94.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Jan 9, 2024

Coverage Status

coverage: 97.167%. remained the same
when pulling 5e0126b on protoroto:bugfix/issue-786-pin-django-cms-version
into 1bfa8ea on nephila:develop.

@protoroto protoroto force-pushed the bugfix/issue-786-pin-django-cms-version branch from 88825aa to 5e0126b Compare January 9, 2024 08:03
@yakky yakky merged commit 2993d5d into nephila:develop Jan 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin Django CMS version in setup
3 participants