Fix FeaturedPostsPlugin get_posts method rendering all posts instead …

…of selected ones
nephila · Dec 22, 2023 · e9512ec · e9512ec
1 parent 25c6d74
commit e9512ec
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/djangocms_blog/models.py b/djangocms_blog/models.py
@@ -611,11 +611,7 @@ def copy_relations(self, oldinstance):
         self.posts.set(oldinstance.posts.all())
 
     def get_posts(self, request, published_only=True):
-        # if self.posts.exists():
-        #     posts = self.post_queryset(request, published_only, selected_posts=self.posts.all())
-        # else:
-        #     posts = self.post_queryset(request, published_only)
-        posts = self.post_queryset(request, published_only)
+        posts = self.post_queryset(request, published_only, selected_posts=self.posts.all())
         return posts
 
 

diff --git a/tests/test_plugins.py b/tests/test_plugins.py
@@ -145,13 +145,13 @@ def test_plugin_featured_cached(self):
         plugin_nocache = add_plugin(ph, "BlogFeaturedPostsPlugin", language="en", app_config=self.app_config_1)
         plugin_nocache.posts.add(posts[0])
         # FIXME: Investigate the correct number of queries expected here
-        with self.assertNumQueries(FuzzyInt(16, 17)):
+        with self.assertNumQueries(FuzzyInt(15, 17)):
             self.render_plugin(pages[0], "en", plugin_nocache)
 
-        with self.assertNumQueries(FuzzyInt(16, 17)):
+        with self.assertNumQueries(FuzzyInt(15, 17)):
             self.render_plugin(pages[0], "en", plugin)
 
-        with self.assertNumQueries(FuzzyInt(16, 17)):
+        with self.assertNumQueries(FuzzyInt(15, 17)):
             rendered = self.render_plugin(pages[0], "en", plugin)
 
         self.assertTrue(rendered.find("<p>first line</p>") > -1)