Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add release workflow #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci: add release workflow #138

wants to merge 1 commit into from

Conversation

ObserverOfTime
Copy link
Contributor

No description provided.

@clason
Copy link
Member

clason commented Oct 20, 2024

Can you explain what exactly this workflow does?

@ObserverOfTime
Copy link
Contributor Author

It creates a release with tree-sitter-vimdoc.wasm and tree-sitter-vimdoc.tar.xz (source code plus generated files).

@clason
Copy link
Member

clason commented Oct 20, 2024

why not tar.gz like normal archives?

@ObserverOfTime
Copy link
Contributor Author

To reduce confusion regarding which archive is correct.

@clason
Copy link
Member

clason commented Oct 20, 2024

That just makes it harder to use; I don't think I want this in nvim-treesitter.

@ObserverOfTime
Copy link
Contributor Author

How is it harder to use? Any platform that supports tar.gz also supports tar.xz.

@clason
Copy link
Member

clason commented Oct 20, 2024

Because now I have to maintain two different "extract archive" functions (again, for little good reason).

@ObserverOfTime
Copy link
Contributor Author

You will have to add a flag that controls which archive to download anyway.
That flag can then switch between tar.xz/xvJf and tar.gz/xvzf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ObserverOfTime @clason