ci: don't run on push #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no real reason to run on push as we're not using any caching.
|
It's good to save CI time, but for low-activity repos I think we should err on the side of explicitness. Reasons in favor of CI on push:
Without this, we don't have a clear concept of "current status", except whatever the last PR was (which also assumes a linear history). |
dundargoc
added a commit
to dundargoc/tree-sitter-vimdoc
that referenced
this pull request
Feb 18, 2024
This reverts commit d1369fc. The reasoning is provided by @justinmk in neovim#122 (comment): It's good to save CI time, but for low-activity repos I think we should err on the side of explicitness. Reasons in favor of CI on push: - to have a baseline, so one can see the history of status checks by looking at master (including squash-merged PRs) - for any (rare) commits that skip the PR process Without this, we don't have a clear concept of "current status", except whatever the last PR was (which also assumes a linear history).
|
Yeah, that's a fair point. I was mostly focused on reducing CI time for the organization but having it run on master is probably more valuable like you said. I've reverted it in #123 |
clason
pushed a commit
that referenced
this pull request
Feb 18, 2024
This reverts commit d1369fc. The reasoning is provided by @justinmk in #122 (comment): It's good to save CI time, but for low-activity repos I think we should err on the side of explicitness. Reasons in favor of CI on push: - to have a baseline, so one can see the history of status checks by looking at master (including squash-merged PRs) - for any (rare) commits that skip the PR process Without this, we don't have a clear concept of "current status", except whatever the last PR was (which also assumes a linear history).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no real reason to run on push as we're not using any caching.