Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated asyncio.get_child_watcher() #584

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace deprecated asyncio.get_child_watcher() #584

wants to merge 2 commits into from
+29 −8

Conversation

cryptomilk
Copy link
Contributor

Use PidfdChildWatcher if os.pidfd_open is available and works, and otherwise use ThreadedChildWatcher which should work in any case.

Fixes #583

@cryptomilk
Copy link
Contributor Author

Looks like that the CI fails before it runs the tests.

@justinmk
Copy link
Member

justinmk commented Jan 3, 2025

expand this to see the test failures:

image 
 FAILED test/test_buffer.py::test_options - OSError: EOF
  FAILED test/test_buffer.py::test_get_exceptions - OSError: EOF
  FAILED test/test_window.py::test_options - OSError: EOF

@cryptomilk cryptomilk force-pushed the asn-fix branch 2 times, most recently from 3b95c0a to accf17f Compare January 4, 2025 08:35
@wookayin
Copy link
Member

wookayin commented Jan 5, 2025 •
edited
Loading

I will try to diagnose the test failure on python 3.13 with nvim-0.11 nightly and send a separate PR to fix it.

UPDATE: this is an upstream issue, see neovim/neovim#31894

@cryptomilk
Copy link
Contributor Author

Oh, locally I'm running nvim 0.10.3 and everything works. GH runs nvim nightly?

@cryptomilk
chore: Bump required msgpack to version 1.0
9659409 
Version 1.0 has been released in 2020.
@cryptomilk
Replace deprecated asyncio.get_child_watcher()
f3e7640 
Use PidfdChildWatcher if os.pidfd_open is available and works, and
otherwise use ThreadedChildWatcher which should work in any case.

Fixes neovim#583
@wookayin wookayin mentioned this pull request Jan 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

broken on python3.14 ('asyncio' has no attribute 'get_child_watcher')
3 participants
@cryptomilk @justinmk @wookayin