Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: misc #24163

Merged
merged 1 commit into from
Apr 30, 2024
Merged

docs: misc #24163

merged 1 commit into from
Apr 30, 2024

Conversation

justinmk
Copy link
Member

@justinmk justinmk commented Jun 26, 2023

Other docs changes

  • ✅ Add :help terminal-events to collect OSC examples
    • OSC 7 example can be tested via:
      printf "\033]7;file://./foo/bar\033\\"
      

@justinmk justinmk changed the title feat(docs): parse [optional] feat(docs): render [optional] args in docs HTML Jun 27, 2023
@justinmk justinmk force-pushed the doc branch 3 times, most recently from ec2009b to a7c8497 Compare July 4, 2023 17:22
@justinmk justinmk force-pushed the doc branch 3 times, most recently from 3c8e874 to 81671d7 Compare January 25, 2024 15:27
@@ -6816,6 +6816,7 @@ A jump table for the options with a short description can be found at |Q_op|.

Level Messages ~
----------------------------------------------------------------------
1 Enables Lua tracing (see above). Does not produce messages.
2 When a file is ":source"'ed, or |shada| file is read or written.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zeertzjq seems intuitive/helpful to have an item for level 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context #27126 #27129

:fold({}, function(t, k, v)
t[k] = v
return t
end) --> { b = 2, d = 4 }
Copy link
Member Author

@justinmk justinmk Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The shadowing of t added unnecessary questions to the old example.
  • Chaining methods emphasizes the "pipeline" aspect of vim.iter.
  • Using acc consistently is a useful signal to readers to notice the accumulator pattern.

@justinmk justinmk force-pushed the doc branch 2 times, most recently from 1519303 to 75b04be Compare January 25, 2024 15:35
@justinmk justinmk marked this pull request as ready for review January 29, 2024 02:32
@github-actions github-actions bot requested a review from clason January 29, 2024 02:51
@justinmk justinmk force-pushed the doc branch 2 times, most recently from 196d8d2 to 000a1c0 Compare January 29, 2024 04:11
@justinmk justinmk marked this pull request as draft January 29, 2024 04:11
@github-actions github-actions bot removed the request for review from clason January 29, 2024 04:13
end
})

To try it out, select the above code and source it with `:'<,'>lua`, then run
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is why :[range]lua is cool.

@justinmk justinmk changed the title feat(docs): render [optional] args in docs HTML docs: misc Apr 25, 2024
@github-actions github-actions bot requested a review from clason April 25, 2024 13:47
@justinmk justinmk force-pushed the doc branch 3 times, most recently from 1d5a88a to 685a232 Compare April 30, 2024 10:44
- Also delete old perl scripts which are not used since 8+ years ago.

fix neovim#23251
fix neovim#27367
ref neovim#2252 (comment)

Co-authored-by: Kevin Pham <[email protected]>
Helped-by: Daniel Kongsgaard <[email protected]>
@justinmk justinmk merged commit 71cf75f into neovim:master Apr 30, 2024
30 of 31 checks passed
@justinmk justinmk deleted the doc branch April 30, 2024 11:30
@github-actions github-actions bot removed the request for review from clason April 30, 2024 11:30
phanen pushed a commit to phanen/neovim that referenced this pull request May 3, 2024
- Also delete old perl scripts which are not used since 8+ years ago.

fix neovim#23251
fix neovim#27367
ref neovim#2252 (comment)

Helped-by: Daniel Kongsgaard <[email protected]>
Co-authored-by: Kevin Pham <[email protected]>
huangyingw pushed a commit to huangyingw/neovim that referenced this pull request May 31, 2024
- Also delete old perl scripts which are not used since 8+ years ago.

fix neovim#23251
fix neovim#27367
ref neovim#2252 (comment)

Helped-by: Daniel Kongsgaard <[email protected]>
Co-authored-by: Kevin Pham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants