This repository has been archived by the owner on Jun 30, 2023. It is now read-only.
[WIP/RFC] session: store exitcode/exitsignal from child #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
commented
Oct 10, 2019
blueyed
changed the title
|
@justinmk btw: I cannot cancel Travis jobs here. |
blueyed
force-pushed
the
child-exitcode
branch
2 times, most recently
from
906af8d to
541dfcf
Compare
blueyed
added a commit
to blueyed/neovim
that referenced
this pull request
Oct 11, 2019
blueyed
commented
Oct 11, 2019
| }, function() | ||
| }, function(code, signal) | ||
| self.exitcode = code | ||
| self.exitsignal = signal | ||
| self:close() |
There was a problem hiding this comment.
Might be good to have this as a module function, so it could be changed / and/or pass in a callback additionally somehow.
Then Neovim could use busted.fail here directly maybe.
@neovim/lua-client team as "Admin" permissions, that's the highest permission... |
justinmk
approved these changes
Oct 17, 2019
blueyed
added a commit
to blueyed/neovim
that referenced
this pull request
Nov 29, 2019
blueyed
force-pushed
the
child-exitcode
branch
from
3b42ad1 to
659ca84
Compare
blueyed
force-pushed
the
child-exitcode
branch
from
659ca84 to
ecd6601
Compare
|
Related/duplicate: #58 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be used in Neovim's tests then to report if the (embedded) child exited non-zero, or due to some signal.
To be used in Neovim's tests: neovim/neovim#11203