Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename and deprecate neovide_transparency to neovide_opacity #2769

Open
wants to merge 7 commits into
base: transparency
Choose a base branch
from

Conversation

lucobellic
Copy link

@lucobellic lucobellic commented Aug 21, 2024

Rename neovide_transparency to neovide_opacity.
Changes to neovide_transparency will update WindowSettings::opacity.

  • Update all documentation and references to use neovide_opacity.
  • Rename WindowSettings transparency to opacity for consistency.
  • Add alias attribute to the SettingGroup macro.
  • Update the test test_read_initial_values with alias.
    Test removed since aliases are excluded from read_initial_values to not trigger deprecation message at startup.
  • Add deprecation message for settings with alias attribute.
    Error: neovide_transparency has now been deprecated, use neovide_opacity instead.

I don't know if a deprecation message is needed and how to properly handle neovide_transparency deprecation, let me know.

What kind of change does this PR introduce?

  • Feature

Did this PR introduce a breaking change?

  • No

Feel free to edit or request any changes

Close #2701

@fredizzimo
Copy link
Member

For the deprecation warning, you can model it after this:
https://github.com/neovide/neovide/blob/000b75c0f3bcfb602967cc5c2e8a9d584be06a02/src/window/macos.rs#L180C12-L180C39

@fredizzimo
Copy link
Member

The macOS build failure is not your fault. Something has changed in the nightly compiler. This might fix it, but I'm not sure:

@lucobellic lucobellic force-pushed the refactor/rename-neovide-transparency branch from 666d448 to b98a19e Compare August 23, 2024 21:16
@lucobellic
Copy link
Author

Code updated with deprecation message.
I just had to exclude transparency key from read_initial_values to avoid triggering the deprecation message at startup.

@lucobellic lucobellic changed the base branch from main to transparency September 7, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: rename and deprecate neovide_transparency to neovide_opacity
2 participants