fix: Another attempt to fix the IME not geting properly enabled #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also throttle the requests. Before these changes fcitx5 would crash on Wayland all the time, so setting it every frame was clearly not the correct way to fix the problem. I guess the real issue was that setting the area when it was not allowed caused the IME system to go into an invalid state.
falcucci
approved these changes
May 24, 2024
zbyna
pushed a commit
to zbyna/neovide
that referenced
this pull request
Jun 1, 2024
…ide#2581) * Set IME allowed status directly after the window creation * Don't set the IME area until the IME system accepts it Also throttle the requests. Before these changes fcitx5 would crash on Wayland all the time, so setting it every frame was clearly not the correct way to fix the problem. I guess the real issue was that setting the area when it was not allowed caused the IME system to go into an invalid state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
The previous attempt of this fix was in:
But it turned out that, the fix caused fcitx to crash all the time, so this fixes it in the correct way, I hope.
NOTE: When I first made this fix, it seemed like it was stil possible to make it go into the wrong state if it was enabled without moving the cursor. But after that I have attempted to repeat it 10s of times without luck, so it's either very random, when it did happen, maybe every other try, and then basically never. Or more likely, fcitx was in some bad state due to my earlier attempts, and therefore caused the problems.
If this happens however, it would be good to capture a log with
WAYLAND_DEBUG=1 neovide. If there is a problem, then it's probably because of some race condition when setting the area immediately after the IME has been enabled, and the wayland log might capture that.Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.